add check to sp_invmod_mont_ct to make sure the#6426
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom May 21, 2023
Merged
add check to sp_invmod_mont_ct to make sure the#6426SparkiDev merged 1 commit intowolfSSL:masterfrom
SparkiDev merged 1 commit intowolfSSL:masterfrom
Conversation
SparkiDev
approved these changes
May 19, 2023
Contributor
|
retest this please |
result integer can hold the range of the modulus
jpbland1
force-pushed
the
invariant-mp-size
branch
from
5bd7a73 to
344c333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
result integer can hold the range of the modulus
Description
sp_invmod_mont_ctputs its result into into ansp_intr but doesn't check that r can hold the full range of the result. I've added this checkFixes zd# 16129
Testing
Tested with Guido's (the big G, the fuzz god) reproducer code
Checklist